test: UserService-Tests vervollständigt

Thomas Ziemer
1 parent 7c0c2ad7
Showing 3 changed files with 96 additions and 10 deletions
src/test/java/net/ziemers/swxercise/lg/user/service/UserServiceTest.java
src/test/java/net/ziemers/swxercise/ui/UserViewControllerTest.java
src/test/resources/net/ziemers/swxercise/testdata/UserServiceTestData.xml
 package net.ziemers.swxercise.lg.user.service;
  
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
 import javax.inject.Inject;
  
 import net.ziemers.swxercise.db.dao.user.UserDao;
@@ -167,18 +170,80 @@ public class UserServiceTest extends JpaTestUtils {
     }
  
     @Test
-    public void testDeleteUserReturnsSuccess() {
+    public void testDeleteUnknownUserByIdReturnsFailure() {
         // TODO Test ist noch zu implementieren
     }
  
     @Test
-    public void testIsUserAllowedReturnsSuccess() {
+    public void testDeleteSessionUserReturnsSuccess() {
         // TODO Test ist noch zu implementieren
     }
  
     @Test
-    public void testIsUserAllowedReturnsFailure() {
-        // TODO Test ist noch zu implementieren
+    @InRequestScope
+    public void testIsNotLoggedInUserAllowedReturnsSuccess() {
+
+        when()
+                .isUserAllowed(new HashSet<String>(Arrays.asList("NOT_LOGGED_IN")));
+
+        then()
+                .assertIsUserAllowedSuccess();
+    }
+
+    @Test
+    @InRequestScope
+    public void testIsNotLoggedInUserAllowedReturnsFailure() {
+
+        when()
+                .isUserAllowed(new HashSet<String>(Arrays.asList("LOGGED_IN")));
+
+        then()
+                .assertIsUserAllowedFailure();
+    }
+
+    @Test
+    @InRequestScope
+    public void testIsSessionUserAllowedReturnsSuccess() {
+
+        given()
+                .userDto(EXISTING_USERNAME_TEST)
+                .loginUser(EXISTING_PASSWORD_TEST);
+
+        when()
+                .isUserAllowed(new HashSet<String>(Arrays.asList("LOGGED_IN")));
+
+        then()
+                .assertIsUserAllowedSuccess();
+    }
+
+    @Test
+    @InRequestScope
+    public void testIsAdminUserAllowedReturnsSuccess() {
+
+      given()
+              .userDto(EXISTING_USERNAME_TEST)
+              .loginUser(EXISTING_PASSWORD_TEST);
+
+      when()
+              .isUserAllowed(new HashSet<String>(Arrays.asList("ADMIN")));
+
+      then()
+              .assertIsUserAllowedSuccess();
+    }
+
+    @Test
+    @InRequestScope
+    public void testIsUserWithUnknownRoleAllowedReturnsFailure() {
+
+      given()
+              .userDto(EXISTING_USERNAME_TEST)
+              .loginUser(EXISTING_PASSWORD_TEST);
+
+      when()
+              .isUserAllowed(new HashSet<String>(Arrays.asList("UNKNOWN_ROLE")));
+
+      then()
+              .assertIsUserAllowedFailure();
     }
  
     // given
@@ -237,6 +302,11 @@ public class UserServiceTest extends JpaTestUtils {
         return this;
     }
  
+    private UserServiceTest isUserAllowed(final Set<String> rightsSet) {
+        actual = underTest.isUserAllowed(rightsSet);
+        return this;
+    }
+
     // then
  
     private UserServiceTest then() {
@@ -276,4 +346,12 @@ public class UserServiceTest extends JpaTestUtils {
         assertEquals(EXISTING_USERNAME_TEST, user.getProfile().getUsername());
     }
  
+    private void assertIsUserAllowedSuccess() {
+        assertTrue(actual);
+    }
+
+    private void assertIsUserAllowedFailure() {
+        assertFalse(actual);
+    }
+
 }
@@ -77,7 +77,7 @@ public class UserViewControllerTest {
     }
  
     @Test
-    public void testGetUserReturnsUserJson() {
+    public void testGetSessionUserReturnsUserJson() {
  
         doing()
                 .getUser();
@@ -113,7 +113,7 @@ public class UserViewControllerTest {
     }
  
     @Test
-    public void testUpdateLoggedInUserReturnsSuccess() {
+    public void testUpdateSessionUserReturnsSuccess() {
  
         given()
                 .userDto();
@@ -126,7 +126,7 @@ public class UserViewControllerTest {
     }
  
     @Test
-    public void testUpdateSpecificUserReturnsSuccess() {
+    public void testUpdateUserByIdReturnsSuccess() {
  
         given()
                 .userDto();
@@ -144,6 +144,11 @@ public class UserViewControllerTest {
     }
  
     @Test
+    public void testDeleteUnknownUserByIdReturnsFailure() {
+        // TODO Test ist noch zu implementieren
+    }
+
+    @Test
     public void testDeleteSessionUserReturnsSuccess() {
         // TODO Test ist noch zu implementieren
     }
@@ -162,7 +167,7 @@ public class UserViewControllerTest {
     }
  
     @Test
-    public void testLoginNonExistingUserReturnsFailure() {
+    public void testLoginUserReturnsFailure() {
  
         given()
                 .userDto();
@@ -195,7 +200,7 @@ public class UserViewControllerTest {
         return this;
     }
  
-    // doing
+    // doing (when)
  
     private UserViewControllerTest doing() {
         return this;
 <?xml version="1.0" encoding="UTF-8"?>
 <dataset>
+    <Role id="3" name="name_role_empty"/>
+    <Role id="4" name="name_role_admin"/>
+    <Role_rights Role_id="4" rights="ADMIN"/>
     <!-- die Gross-/Kleinschreibung scheint unter bestimmten Bedingungen von Bedeutung zu sein! -->
     <!-- das Kennwort ist "secret" -->
-    <Profile id="1" username="username_profile" passwordHash="9EOZEsheQcXixUO/XW/vPwRlZh9NMyHppli2qKe3U9+Y0EHhtJU1AA56pkduCGsSbp8VZ7so/62+3cftxBhJGg==" hashAlgorithm="SHA512" salt="FuQll2Av59se1r1Dc4WEPDmzZw4="/>
+    <Profile id="1" role_id="4" username="username_profile" passwordHash="9EOZEsheQcXixUO/XW/vPwRlZh9NMyHppli2qKe3U9+Y0EHhtJU1AA56pkduCGsSbp8VZ7so/62+3cftxBhJGg==" hashAlgorithm="SHA512" salt="FuQll2Av59se1r1Dc4WEPDmzZw4="/>
     <User id="2" firstname="firstname_user" lastname="lastname_user" profile_id="1"/>
 </dataset>