test: Stubs für RoleViewController- und RoleService-Tests angelegt

Thomas Ziemer
1 parent 1d77dd1a
Showing 3 changed files with 152 additions and 22 deletions
src/test/java/net/ziemers/swxercise/db/utils/JpaTestUtils.java
src/test/java/net/ziemers/swxercise/lg/user/service/RoleServiceTest.java
src/test/java/net/ziemers/swxercise/ui/RoleViewControllerTest.java
@@ -74,6 +74,7 @@ public class JpaTestUtils {
         return em;
     }
  
+    @SuppressWarnings("unused")
     protected void clearEm() {
         em = null;
     }
@@ -118,16 +119,17 @@ public class JpaTestUtils {
         return emf;
     }
  
-    public void txBegin() {
+    protected void txBegin() {
         tx = getEm().getTransaction();
         tx.begin();
     }
  
-    public void txCommit() {
+    protected void txCommit() {
         tx.commit();
     }
  
-    public void txRollback() {
+    @SuppressWarnings("unused")
+    protected void txRollback() {
         tx.rollback();
     }
  
@@ -151,7 +153,8 @@ public class JpaTestUtils {
             resourceAsStream = JpaTestUtils.class.getClassLoader().getResourceAsStream(NET_ZIEMERS_SWXERCISE_PKG + resourceName);
             dataSet = flatXmlDataSetBuilder.build(resourceAsStream);
         } catch (Exception e) {
-            throw e;
+            logger.warn("Exception while reading test data definitions file named \"{}\". If your tests fail, check existence of file!", resourceName);
+            // throw e;
         } finally {
             if (dtdStream != null) {
                 dtdStream.close();
@@ -171,20 +174,22 @@ public class JpaTestUtils {
      * @throws Exception wenn dabei etwas schiefläuft
      */
     protected void initDbWith(String resourceName) throws Exception {
-        IDataSet dataset = readDataset(resourceName);
-        try {
-            SessionImpl delegate = (SessionImpl) this.getEm().getDelegate();
-            DatabaseConnection connection = new DatabaseConnection(delegate.connection());
-            IMetadataHandler mysqlHandler = new MySqlMetadataHandler();
-            IDataTypeFactory mySqlDataTypeFactory = new MySqlDataTypeFactory();
-            connection.getConfig().setProperty(DatabaseConfig.PROPERTY_METADATA_HANDLER, mysqlHandler);
-            connection.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, mySqlDataTypeFactory);
-            DatabaseOperation.INSERT.execute(connection, dataset);
-        } catch (DatabaseUnitException qe) {
-            logger.warn("Database entries already inserted. If your tests fail, check your sql inserts for constraint violations!");
-            logger.warn(qe.getMessage());
-            logger.warn(qe.getMessage(), qe);
-            throw qe;
+        final IDataSet dataset = readDataset(resourceName);
+        if (dataset != null) {
+            try {
+                SessionImpl delegate = (SessionImpl) this.getEm().getDelegate();
+                DatabaseConnection connection = new DatabaseConnection(delegate.connection());
+                IMetadataHandler mysqlHandler = new MySqlMetadataHandler();
+                IDataTypeFactory mySqlDataTypeFactory = new MySqlDataTypeFactory();
+                connection.getConfig().setProperty(DatabaseConfig.PROPERTY_METADATA_HANDLER, mysqlHandler);
+                connection.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, mySqlDataTypeFactory);
+                DatabaseOperation.INSERT.execute(connection, dataset);
+            } catch (DatabaseUnitException qe) {
+                logger.warn("Database entries already inserted. If your tests fail, check your sql inserts for constraint violations!");
+                logger.warn(qe.getMessage());
+                logger.warn(qe.getMessage(), qe);
+                throw qe;
+            }
         }
     }
  
@@ -193,7 +198,7 @@ public class JpaTestUtils {
      *
      * @throws Exception Wirft eventuelle SQL- und I/O-Exceptions
      */
-    public void cleanDb() throws Exception {
+    protected void cleanDb() throws Exception {
         String schema = getCurrentSchema();
         List<String> tables = getTableNamesToBeEmptied();
         getEm().getTransaction().begin();
@@ -219,7 +224,7 @@ public class JpaTestUtils {
         return null;
     }
  
-    public List<String> getTableNamesToBeEmptied() throws Exception {
+    private List<String> getTableNamesToBeEmptied() throws Exception {
         return showTablesNotEmpty(getCurrentSchema());
     }
  
@@ -240,7 +245,7 @@ public class JpaTestUtils {
      *
      * @return eine Liste der zu ignorierenden Tabellen
      */
-    public List<String> getSkippingTables() {
+    private List<String> getSkippingTables() {
         return Arrays.asList(
                 "hibernate_sequence",
                 "schema_version"); // FlywayDB Metatable
@@ -255,7 +260,7 @@ public class JpaTestUtils {
         return result;
     }
  
-    public String getTruncateStatement(String schema, String table) {
+    private String getTruncateStatement(String schema, String table) {
         return String.format("DELETE FROM %s.%s;", schema, table);
     }
  
+package net.ziemers.swxercise.lg.user.service;
+
+import net.ziemers.swxercise.db.dao.user.UserDao;
+import net.ziemers.swxercise.db.utils.JpaTestUtils;
+import org.jglue.cdiunit.CdiRunner;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import javax.inject.Inject;
+
+/**
+ * Testing your Java CDI application with CDI-Unit couldn't be easier.
+ * Just specify @RunWith(CdiRunner.class) on your JUnit test class
+ * to enable injection directly into the test class.
+ *
+ * To test classes in isolation we shouldn't be using their dependencies.
+ * Instead we should be using a mock. There are many mocking libraries out
+ * there, however CDI-Unit has extra support for Mockito @Mock annotations.
+ *
+ * Quelle: http://jglue.org/cdi-unit-user-guide/
+ */
+@RunWith(CdiRunner.class)
+public class RoleServiceTest extends JpaTestUtils {
+
+    private static boolean dbInitialized;
+
+    @Inject
+    private UserDao userDao;
+
+    @Inject
+    private UserService underTest;
+
+    @Before
+    public void setUp() throws Exception {
+        if (!dbInitialized) {
+            cleanDb();
+            initDbWith("RoleServiceTestData.xml");
+            dbInitialized = true;
+        }
+    }
+
+    @Test
+    public void testSomething() {
+
+        given();
+
+        when();
+
+        then();
+    }
+
+    // given
+
+    private RoleServiceTest given() {
+        return this;
+    }
+
+    // when
+
+    private RoleServiceTest when() {
+        return this;
+    }
+
+    // then
+
+    private RoleServiceTest then() {
+        return this;
+    }
+
+}
+package net.ziemers.swxercise.ui;
+
+import net.ziemers.swxercise.lg.user.service.RoleService;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+
+@RunWith(MockitoJUnitRunner.class)
+public class RoleViewControllerTest {
+
+    /*
+     * You have the @InjectMocks annotation which tries to do constructor,
+     * method and field dependency injection based on the type.
+     */
+    @InjectMocks
+    private RoleViewController underTest;
+
+    /*
+     * Mockito allows to configure the return values of its mocks via a fluent API.
+     * Unspecified method calls return "empty" values
+     */
+    @Mock
+    private RoleService roleService;
+
+    @Test public void testSomething() {
+
+        given();
+
+        doing();
+
+        then();
+    }
+
+    // given
+
+    private RoleViewControllerTest given() {
+        return this;
+    }
+
+    // doing (when)
+
+    private RoleViewControllerTest doing() {
+        return this;
+    }
+
+    // then
+
+    private RoleViewControllerTest then() {
+        return this;
+    }
+
+}