test: Vorlage zum UserServiceTest

Thomas Ziemer
1 parent b9b94a9f
Showing 7 changed files with 130 additions and 23 deletions
README.md
pom.xml
src/test/java/net/ziemers/swxercise/lg/testdata/testdatabuilder/user/ProfileTestDataBuilder.java
src/test/java/net/ziemers/swxercise/lg/testdata/testdatabuilder/user/UserDtoTestDataBuilder.java
src/test/java/net/ziemers/swxercise/lg/testdata/testdatabuilder/user/UserTestDataBuilder.java
src/test/java/net/ziemers/swxercise/lg/user/service/UserServiceTest.java
src/test/java/net/ziemers/swxercise/ui/UserViewControllerTest.java
@@ -3,13 +3,12 @@
 ## Projekt-Voraussetzungen
 - Versionsverwaltungswerkzeug "Git"
-- installiertes Java 8 JDK (mit Dokumentation)
-- eine Java-Entwicklungsumgebung ("Eclipse", "JetBrains IntelliJ IDEA", "NetBeans" o.ä.)
+- Installiertes Java 8 JDK (mit Dokumentation)
+- Eine Java-Entwicklungsumgebung ("Eclipse", "JetBrains IntelliJ IDEA", "NetBeans" o.ä.)
 - JEE-Application Server "JBoss WildFly Version 8.2.1-final"
-- Plugin "JBoss Tools" (nur für Eclipse)
-- Build-System "maven"
-- ein relationales Datenbankverwaltungssystem ("MySQL" empfohlen, oder "MariaDB", "PostgreSQL", "Oracle Express" etc.)
-- ein REST-Client (empfohlen "Advanced Rest Client Application" für Chrome)
+- Build-System "maven" (optional)
+- Ein relationales Datenbankverwaltungssystem mit JDBC-Anbindung ("MySQL" empfohlen, oder "MariaDB", "PostgreSQL", "Oracle Express" etc.)
+- Ein REST-Client (empfohlen "Advanced Rest Client Application" für Chrome)
 ## Java-Projekt herunterladen
@@ -9,6 +9,8 @@
 	<url>http://maven.apache.org</url>
 	<properties>
+		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
 		<mvn-compiler-plugin-version>3.3</mvn-compiler-plugin-version>
 		<jee-version>7.0</jee-version>
 		<java-version>1.8</java-version>
@@ -7,11 +7,11 @@ import javax.persistence.EntityManager;
 public class ProfileTestDataBuilder extends AbstractTestDataBuilder {
-    private String username = "tziemer";
+    private String username = "hbloed";
     private String password = "secret";
-    private String mailaddress = "tziemer@ziemers.net";
+    private String mailaddress = "hbloed@ziemers.net";
     public ProfileTestDataBuilder(final EntityManager em) {
         super(em);
+package net.ziemers.swxercise.lg.testdata.testdatabuilder.user;
+
+import net.ziemers.swxercise.lg.testdata.testdatabuilder.AbstractTestDataBuilder;
+import net.ziemers.swxercise.lg.user.dto.UserDto;
+
+import javax.persistence.EntityManager;
+
+public class UserDtoTestDataBuilder extends AbstractTestDataBuilder<UserDto> {
+
+    private String username = "hein";
+
+    private String password = "secret";
+
+    private String firstname = "Hein";
+
+    private String lastname = "Blöd";
+
+    private String mailaddress;
+
+    @Override
+    public UserDto build() {
+        return new UserDto()
+                .withUsername(username)
+                .withPassword(password)
+                .withFirstname(firstname)
+                .withLastname(lastname)
+                .withMailaddress(mailaddress);
+    }
+
+    public UserDtoTestDataBuilder withUsername(final String username) {
+        this.username = username;
+        return this;
+    }
+
+    public UserDtoTestDataBuilder withPassword(final String password) {
+        this.password = password;
+        return this;
+    }
+
+    public UserDtoTestDataBuilder withFirstname(final String firstname) {
+        this.firstname = firstname;
+        return this;
+    }
+
+    public UserDtoTestDataBuilder withLastname(final String lastname) {
+        this.lastname = lastname;
+        return this;
+    }
+
+    public UserDtoTestDataBuilder withMailaddr(final String mailaddress) {
+        this.mailaddress = mailaddress;
+        return this;
+    }
+
+}
@@ -11,7 +11,7 @@ public class UserTestDataBuilder extends AbstractTestDataBuilder&lt;User&gt; {
     private String firstname = "Hein";
-    private String lastname = "Bloed";
+    private String lastname = "Blöd";
     private Profile profile;
@@ -22,6 +22,10 @@ public class UserTestDataBuilder extends AbstractTestDataBuilder&lt;User&gt; {
         profile = new ProfileTestDataBuilder(em).build();
     }
+    public UserTestDataBuilder() {
+        this(null);
+    }
+
     @Override
     public User build() {
         return new User(firstname, lastname)
@@ -2,9 +2,14 @@ package net.ziemers.swxercise.lg.user.service;
 import javax.inject.Inject;
+import net.ziemers.swxercise.db.dao.user.UserDao;
 import net.ziemers.swxercise.db.utils.JpaTestUtils;
+import net.ziemers.swxercise.lg.model.user.User;
+import net.ziemers.swxercise.lg.testdata.testdatabuilder.user.UserDtoTestDataBuilder;
 import net.ziemers.swxercise.lg.user.dto.UserDto;
+import static org.junit.Assert.*;
+
 import org.jglue.cdiunit.CdiRunner;
 import org.junit.Before;
 import org.junit.Test;
@@ -22,13 +27,20 @@ import org.junit.runner.RunWith;
 @RunWith(CdiRunner.class)
 public class UserServiceTest extends JpaTestUtils {
+    private static String USERNAME_TEST = "username_test";
+
     private static boolean dbInitialized;
+    private UserDto userDto;
+
+    @Inject
+    private UserDao userDao;
+
     @Inject
     private UserService underTest;
     @Before
-    public void setup() throws Exception {
+    public void setUp() throws Exception {
         if (!dbInitialized) {
             cleanDb();
             //initDbWith("UserService.xml");
@@ -37,18 +49,54 @@ public class UserServiceTest extends JpaTestUtils {
     }
     @Test
-    public void testService() {
-        txBegin();
+    public void testCreateUserReturnsSuccess() {
-        final UserDto dto = new UserDto()
-                .withFirstname("Hein")
-                .withLastname("Blöd")
-                .withUsername("tziemer")
-                .withPassword("secret");
+        given()
+                .userDto();
-        underTest.createUser(dto);
+        when()
+                .createUser();
+        then()
+                .assertCreateSuccess();
+    }
+
+    // given
+
+    private UserServiceTest given() {
+        return this;
+    }
+
+    private UserServiceTest userDto() {
+        userDto = new UserDtoTestDataBuilder()
+                .withUsername(USERNAME_TEST)
+                .build();
+        return this;
+    }
+
+    // when
+
+    private UserServiceTest when() {
+        return this;
+    }
+
+    private UserServiceTest createUser() {
+        txBegin();
+        underTest.createUser(userDto);
         txCommit();
+
+        return this;
+    }
+
+    // then
+
+    private UserServiceTest then() {
+        return this;
+    }
+
+    private void assertCreateSuccess() {
+        final User user = userDao.findByUsername(USERNAME_TEST);
+        assertNotNull(user);
     }
 }
 package net.ziemers.swxercise.ui;
 import net.ziemers.swxercise.lg.model.user.User;
+import net.ziemers.swxercise.lg.testdata.testdatabuilder.user.UserDtoTestDataBuilder;
+import net.ziemers.swxercise.lg.testdata.testdatabuilder.user.UserTestDataBuilder;
 import net.ziemers.swxercise.lg.user.dto.UserDto;
 import net.ziemers.swxercise.lg.user.service.UserService;
 import org.junit.Test;
@@ -101,15 +103,12 @@ public class UserViewControllerTest {
     }
     private UserViewControllerTest userDto() {
-        userDto = new UserDto()
-                .withUsername("hbloed")
-                .withPassword("secret");
-
+        userDto = new UserDtoTestDataBuilder().build();
         return this;
     }
     private UserViewControllerTest user() {
-        user = new User("Hein", "Blöd");
+        user = new UserTestDataBuilder().build();
         return this;
     }